fix: overwrite previous tags on import [FC-0036] by rpenido · Pull Request #33752 · openedx/openedx-platform

rpenido · 2023-11-20T20:02:16Z

Description

Updates the openedx-learning library to change the import endpoint to overwrite previous tags from the target taxonomy.

Supporting Information

Part of [Tagging] "Bare Bones" Update of Existing Taxonomy by Uploading modular-learning#140
Depends on:
- fix: overwrite previous tags on import [FC-0036] openedx-core#121

Testing instructions

Please ensure that the tests cover the expected behavior of the view

Before merge

ToDo: update dependencies after fix: overwrite previous tags on import [FC-0036] openedx-core#121 merge (0d9b82e)

Private-ref: FAL-3536

openedx-webhooks · 2023-11-20T20:02:21Z

Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

open-craft-grove · 2023-11-20T20:15:35Z

Sandbox deploy request received. Deployment will start soon.

open-craft-grove · 2023-11-20T20:38:47Z

Sandbox deployment started.

open-craft-grove · 2023-11-20T21:47:38Z

Sandbox deployment successful.

Sandbox LMS is available at pr-33752-139931.staging.do.opencraft.hosting
Sandbox Studio is available at studio.pr-33752-139931.staging.do.opencraft.hosting

pomegranited

👍

I tested this using my devstack's REST API
I read through the code
~~I checked for accessibility issues~~ N/A
~~Includes documentation~~ N/A
~~User-facing strings are extracted for translation~~ N/A

pomegranited · 2023-11-21T01:36:19Z

@rpenido Could you put FC-0036 in these PR titles? Thanks :)

pomegranited · 2023-11-21T02:12:11Z

openedx-learning==0.3.5 is ready now: https://pypi.org/project/openedx-learning/0.3.5/

Done 0d9b82e!

rpenido · 2023-11-21T02:41:22Z

@rpenido Could you put FC-0036 in these PR titles? Thanks :)

This is for all PRs (in all repositories) related to Step 3?

open-craft-grove · 2023-11-21T02:45:37Z

Sandbox update request received. Deployment will start soon.

open-craft-grove · 2023-11-21T02:49:57Z

Sandbox deployment started.

open-craft-grove · 2023-11-21T03:21:34Z

Sandbox deployment successful.

Sandbox LMS is available at pr-33752-139931.staging.do.opencraft.hosting
Sandbox Studio is available at studio.pr-33752-139931.staging.do.opencraft.hosting

open-craft-grove · 2023-11-21T12:00:35Z

Sandbox update request received. Deployment will start soon.

open-craft-grove · 2023-11-21T12:27:59Z

Sandbox deployment started.

open-craft-grove · 2023-11-21T12:59:54Z

Sandbox deployment successful.

Sandbox LMS is available at pr-33752-139931.staging.do.opencraft.hosting
Sandbox Studio is available at studio.pr-33752-139931.staging.do.opencraft.hosting

pomegranited · 2023-11-21T22:44:57Z

@rpenido Could you put FC-0036 in these PR titles? Thanks :)
This is for all PRs (in all repositories) related to Step 3?

Yep!

open-craft-grove · 2023-11-22T13:30:39Z

Sandbox update request received. Deployment will start soon.

open-craft-grove · 2023-11-22T13:34:50Z

Sandbox deployment started.

open-craft-grove · 2023-11-22T14:09:11Z

Sandbox deployment successful.

Sandbox LMS is available at pr-33752-139931.staging.do.opencraft.hosting
Sandbox Studio is available at studio.pr-33752-139931.staging.do.opencraft.hosting

bradenmacdonald

LGTM but I won't be able to merge this until Monday due to the Thanksgiving holiday.

openedx-webhooks · 2023-11-27T19:43:25Z

@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

open-craft-grove · 2023-11-27T19:45:21Z

Sandbox destroy request received.

edx-pipeline-bot · 2023-11-27T20:59:58Z

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

edx-pipeline-bot · 2023-11-27T21:22:01Z

2U Release Notice: This PR has been deployed to the edX production environment.

edx-pipeline-bot · 2023-11-27T21:22:01Z

2U Release Notice: This PR has been deployed to the edX production environment.

fix: overwrite previous tags on import

b9be898

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 20, 2023

rpenido requested a review from pomegranited November 20, 2023 20:04

mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Nov 20, 2023

pomegranited approved these changes Nov 21, 2023

View reviewed changes

rpenido changed the title ~~fix: overwrite previous tags on import~~ fix: overwrite previous tags on import [FC-0036] Nov 21, 2023

pomegranited reviewed Nov 21, 2023

View reviewed changes

rpenido force-pushed the rpenido/fal-3536-overwrite-tags-on-import branch from c9a3f73 to b9be898 Compare November 21, 2023 02:32

chore: update deps

0d9b82e

Merge branch 'master' into rpenido/fal-3536-overwrite-tags-on-import

3b7e273

Merge branch 'master' into rpenido/fal-3536-overwrite-tags-on-import

8270e55

rpenido mentioned this pull request Nov 22, 2023

feat: import tags to existing taxonomy [FC-0036] openedx/frontend-app-authoring#708

Closed

pomegranited requested a review from bradenmacdonald November 22, 2023 23:44

bradenmacdonald approved these changes Nov 22, 2023

View reviewed changes

rpenido mentioned this pull request Nov 24, 2023

feat: add import taxonomy feature [FC-0036] openedx/frontend-app-authoring#675

Merged

bradenmacdonald merged commit 6d4463d into openedx:master Nov 27, 2023

bradenmacdonald deleted the rpenido/fal-3536-overwrite-tags-on-import branch November 27, 2023 19:43

Uh oh!

Conversation

rpenido commented Nov 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Supporting Information

Testing instructions

Before merge

Uh oh!

openedx-webhooks commented Nov 20, 2023

Uh oh!

open-craft-grove commented Nov 20, 2023

Uh oh!

open-craft-grove commented Nov 20, 2023

Uh oh!

open-craft-grove commented Nov 20, 2023

Uh oh!

pomegranited left a comment

Choose a reason for hiding this comment

Uh oh!

pomegranited commented Nov 21, 2023

Uh oh!

pomegranited Nov 21, 2023

Choose a reason for hiding this comment

Uh oh!

rpenido Nov 21, 2023

Choose a reason for hiding this comment

Uh oh!

rpenido commented Nov 21, 2023

Uh oh!

open-craft-grove commented Nov 21, 2023

Uh oh!

open-craft-grove commented Nov 21, 2023

Uh oh!

open-craft-grove commented Nov 21, 2023

Uh oh!

open-craft-grove commented Nov 21, 2023

Uh oh!

open-craft-grove commented Nov 21, 2023

Uh oh!

open-craft-grove commented Nov 21, 2023

Uh oh!

pomegranited commented Nov 21, 2023

Uh oh!

open-craft-grove commented Nov 22, 2023

Uh oh!

open-craft-grove commented Nov 22, 2023

Uh oh!

open-craft-grove commented Nov 22, 2023

Uh oh!

bradenmacdonald left a comment

Choose a reason for hiding this comment

Uh oh!

openedx-webhooks commented Nov 27, 2023

Uh oh!

open-craft-grove commented Nov 27, 2023

Uh oh!

edx-pipeline-bot commented Nov 27, 2023

Uh oh!

edx-pipeline-bot commented Nov 27, 2023

Uh oh!

edx-pipeline-bot commented Nov 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

rpenido commented Nov 20, 2023 •

edited

Loading